Skip to content

SA1135 A using directive is not qualified #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

SA1135 A using directive is not qualified #7264

merged 1 commit into from
Jan 12, 2022

Conversation

@elachlan
Copy link
Contributor

@elachlan elachlan commented Jan 12, 2022

@elachlan elachlan mentioned this pull request Jan 12, 2022
Open
rainersigwald
rainersigwald approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first reaction was "why are these usings even inside the namespace in the first place?" but this seems fine.

@Forgind Forgind merged commit 2518d1a into dotnet:main Jan 12, 2022
@elachlan
Copy link
Contributor Author

elachlan commented Jan 12, 2022

My first reaction was "why are these usings even inside the namespace in the first place?" but this seems fine.

There will be another PR for the location. It is very strange, I must say.

@elachlan elachlan deleted the SA1135 branch January 12, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

+1 more reviewer

@Forgind Forgind Forgind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elachlan @rainersigwald @Forgind